fix(types): correct TypeCast's Next callback to return unknown #3129
Conversation
Fixes typeCast Next type appears to be incorrect sidorares#3122
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3129 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 71 71
Lines 12890 12890
Branches 1355 1354 -1
=======================================
Hits 11361 11361
Misses 1529 1529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks, @bbugh.
I've suggested some rollback changes to the website's test files, or if you prefer, the CI error is due to the last EOL character in ./website/test/fixtures/external-code-embed/QueryOptions.txt 🤝
| @@ -32,7 +32,7 @@ export interface QueryOptions { | |||
| * Determines if column values should be converted to native JavaScript types. It is not recommended (and may go away / change in the future) | |||
| * to disable type casting, but you can currently do so on either the connection or query level. (Default: true) | |||
| * | |||
| * You can also specify a function (field: any, next: () => void) => {} to do the type casting yourself. | |||
| * You can also specify a function (field: any, next: () => unknown) => {} to do the type casting yourself. | |||
There was a problem hiding this comment.
No need to change the test fixtures or resources in ./website/test. They just ensure string extractions in the ExternalCodeEmbed tests and are for internal use only 🙋🏻♂️
| @@ -41,7 +41,7 @@ export interface QueryOptions { | |||
| * Determines if column values should be converted to native JavaScript types. It is not recommended (and may go away / change in the future) | |||
| * to disable type casting, but you can currently do so on either the connection or query level. (Default: true) | |||
| * | |||
| * You can also specify a function (field: any, next: () => void) => {} to do the type casting yourself. | |||
| * You can also specify a function (field: any, next: () => unknown) => {} to do the type casting yourself. | |||
Fixes "typeCast Next type appears to be incorrect" #3122
Also replaced references to the old incorrect type signature in referencing comments