Use takis again #706
Closed
Use takis again #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
takis is at tcp level, while wait-up script allows to wait until you can actually connect to database. Without that some test randomly fail if they start after docker is up but before server finished initialisation |
|
not sure why it was hanging, I did re-run once and it worked |
|
I have been having Travis CI jobs hanging in various projects randomly for the past week. It may have been just something wrong with the Travis job itself (maybe some kind of infra problem?). I have to keep restarting jobs every so often because they'll hang forever. |
|
Good point, we should use both |
|
why both then? |
|
Because build keep pinging mysql server even if its not listening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some builds are hanging forever in this pr. Reverted back to using takis again, which I think is more reliable.
If there is any reason for not using takis, please let me know