Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RefFromWasmAbi should not drop JsType #33

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: RefFromWasmAbi should not drop JsType #33

merged 2 commits into from
Apr 23, 2024

Conversation

fhilgers
Copy link

@fhilgers fhilgers commented Apr 17, 2024

Fixes #32

@siefkenj
Copy link
Owner

Thanks for this! Is there any way to get a test for this behavior?

@siefkenj siefkenj merged commit 9e2203b into siefkenj:main Apr 23, 2024
3 checks passed
@Pantamis
Copy link

Post Merge ACK

I ran the proposed test with and without the fix of this PR. With the fix the test pass, without the fix the test fail when it unwraps the result of validate_simple_data_ref with free of stack slot 127 suggesting that indeed, the JS value was freed during the two invocations of the validation closure in the ref case.

Big thank you for the fix and especially the explanation in the linked issue 🙏 I learnt so much from it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RefFromWasmAbi causes panic in dev builds but not in prod
3 participants