fix(landing-page): pass loginAlert action and translationParams#1556
fix(landing-page): pass loginAlert action and translationParams#1556
Conversation
There was a problem hiding this comment.
Code Review
The pull request correctly implements the passing of action and translationParams from the loginAlert object to the si-inline-notification component. This aligns with the AlertConfig model and ensures that the notification can display actions and use translation parameters as intended. The changes are straightforward and resolve the described issue effectively.
|
Documentation. Coverage Reports: |
dauriamarco
left a comment
There was a problem hiding this comment.
Thank you @ljanner 👌 Could you also add an example for this and maybe an e2e to test it? In the si-landing-page-single-sign-on-login.ts for example:
ngOnInit(): void {
// note: this is normally in translation file, this is for demo proposes only
this.translate.set('DEMO.CONFIRM_LOGIN_MSG', 'Hi {{user}}! You have logged in.');
}
ssoLogin(): void {
this.loginAlert.set({
severity: 'success',
message: 'DEMO.CONFIRM_LOGIN_MSG',
translationParams: { user: 'User' }
});
}b07be02 to
1865997
Compare
Thanks for the really helpful snippet, added an e2e test 🙏 |
3683bbe to
1865997
Compare
1865997 to
e360148
Compare
Resolves #1555