feat(landing-page): provide default texts for registerNowLink and forgotPasswordLink#1560
feat(landing-page): provide default texts for registerNowLink and forgotPasswordLink#1560dauriamarco wants to merge 1 commit intomainfrom
registerNowLink and forgotPasswordLink#1560Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces default translated labels for the forgotPasswordLink and registerNowLink in the si-login-basic component. This improves user experience by providing sensible defaults when these links are not fully configured. The changes also include updates to the API golden files and example usage to reflect these new defaults. The code is well-structured and follows good practices for Angular components and internationalization.
| @let forgotPasswordLink = this.effectiveForgotPasswordLink(); | ||
| @let registerNowLink = this.effectiveRegisterNowLink(); |
There was a problem hiding this comment.
The template now uses effectiveForgotPasswordLink() and effectiveRegisterNowLink() which correctly encapsulate the logic for providing default titles. This is a good improvement for maintainability and consistency.
| booleanAttribute, | ||
| ChangeDetectionStrategy, | ||
| Component, | ||
| computed, |
There was a problem hiding this comment.
The computed import is added, which is necessary for the new effectiveForgotPasswordLink and effectiveRegisterNowLink properties. This is a correct addition.
| readonly passwordLabel = input(t(() => $localize`:@@SI_LOGIN_BASIC.PASSWORD:Password`)); | ||
| /** | ||
| * Config for Forgot Password link. | ||
| * If `title` is omitted, a default translated label is used. |
There was a problem hiding this comment.
The JSDoc for forgotPasswordLink is updated to reflect the new behavior of providing a default translated label if the title is omitted. This improves the clarity of the component's API.
| readonly forgotPasswordLink = input<Link>(); | ||
| /** | ||
| * Config for Register Now link. | ||
| * If `title` is omitted, a default translated label is used. |
There was a problem hiding this comment.
The JSDoc for registerNowLink is updated to reflect the new behavior of providing a default translated label if the title is omitted. This is consistent with the forgotPasswordLink documentation.
| private readonly defaultForgotPasswordTitle = t( | ||
| () => $localize`:@@SI_LOGIN_BASIC.FORGOT_PASSWORD:Forgot password` | ||
| ); |
There was a problem hiding this comment.
The defaultForgotPasswordTitle is correctly defined using $localize for internationalization. This ensures that a default translated label is available for the 'Forgot password' link.
| protected readonly effectiveRegisterNowLink = computed(() => { | ||
| const link = this.registerNowLink(); | ||
| return !!link && link.title ? link : { ...link, title: this.defaultRegisterNowTitle }; | ||
| }); |
There was a problem hiding this comment.
The effectiveRegisterNowLink computed signal correctly checks if registerNowLink has a title. If not, it provides the defaultRegisterNowTitle. This mirrors the logic for the forgot password link, ensuring consistency.
| [forgotPasswordLink]="{ href: 'https://myid.siemens.com/help/' }" | ||
| [registerNowLink]="{ href: 'https://myid.siemens.com/help/' }" |
There was a problem hiding this comment.
The example usage for forgotPasswordLink is updated to omit the title property, relying on the new default translation. This demonstrates the intended usage of the new feature.
| href: 'https://myid.siemens.com/help/' | ||
| }" | ||
| [forgotPasswordLink]="{ href: 'https://myid.siemens.com/help/' }" | ||
| [registerNowLink]="{ href: 'https://myid.siemens.com/help/' }" |
There was a problem hiding this comment.
The example usage for registerNowLink is updated to omit the title property, relying on the new default translation. This is consistent with the forgotPasswordLink example.
| title: 'FORM.REGISTER_NOW', | ||
| href: 'https://myid.siemens.com/help/' | ||
| }" | ||
| [forgotPasswordLink]="{ href: 'https://myid.siemens.com/help/' }" |
There was a problem hiding this comment.
The example usage for forgotPasswordLink is updated to omit the title property, relying on the new default translation. This demonstrates the intended usage of the new feature.
| href: 'https://myid.siemens.com/help/' | ||
| }" | ||
| [forgotPasswordLink]="{ href: 'https://myid.siemens.com/help/' }" | ||
| [registerNowLink]="{ href: 'https://myid.siemens.com/help/' }" |
There was a problem hiding this comment.
The example usage for registerNowLink is updated to omit the title property, relying on the new default translation. This is consistent with the forgotPasswordLink example.
dauriamarco
changed the title
registerNowLink and forgotPasswordLinkregisterNowLink and forgotPasswordLink
|
|
|
Documentation. Coverage Reports: |
2 participants
Resolves #1434.