-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: OpenSSL compatibility check and macOS #67
Conversation
cd48e8c
to
d0ea0d1
Compare
|
Would this work if rebased on #68? |
76ce89b
to
dd1eb06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice.
Some small points for improvements.
cd build-with-libcmp | ||
USE_LIBCMP=1 cmake -S .. -B . | ||
make clean build | ||
DESTDIR=tmp make install uninstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add
cd ..
make -f Makefile_v1 test_Mock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh, with macOS the HTTP-based tests hang,
I believe due to waiting for interactive approval for the server to receive input on a local port.
If we do not quickly find way of fixing this, I suggest replacing
make -f Makefile_v1 test_Mock`
by just
make -f Makefile_v1
./cmpClient --help
run: | | ||
make -f Makefile_v1 | ||
make -f Makefile_v1 clean_all | ||
USE_LIBCMP=1 STATIC_LIBCMP=1 make -f Makefile_v1 build_no_tls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add:
make -f Makefile_v1 test_Mock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the current build failure is due to inconsistency of the build configuration after
USE_LIBCMP=1 STATIC_LIBCMP=1 make -f Makefile_v1 build_no_tls
.
So instead of adding make -f Makefile_v1 test_Mock
thereafter,
one could replace the earlier make -f Makefile_v1
by make -f Makefile_v1 test_Mock
.
or insert make -f Makefile_v1 clean_all
before the mock test build,
of more efficiently:
augment the new make -f Makefile_v1 test_Mock
by
USE_LIBCMP=1 STATIC_LIBCMP=1 make -f Makefile_v1 test_Mock
One of the two typos is also in the file name |
29f67f3
to
3857dca
Compare
2c4f453
to
4853603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason, steps.cache-openssl.outputs.cache-hit
seems to nave yield 'true'.
I suggest printing the actual value to help find out what went wrong.
33b93c8
to
701861f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ready to merge - |
701861f
to
b5840ef
Compare
|
Motivation
issue #46
Proposed Changes
Add new CI pipeline.
Test Plan
Test is not required