fix: strict

siemens · Oct 10, 2024 · cc9c40f · cc9c40f
1 parent edf3bfb
commit cc9c40f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/packages/core/src/components.d.ts b/packages/core/src/components.d.ts
@@ -5855,7 +5855,7 @@ declare namespace LocalJSX {
         /**
           * Icon of the Header
          */
-        "icon"?: string;
+        "icon": string;
         /**
           * Icon color
          */

diff --git a/packages/core/src/components/modal-header/modal-header.tsx b/packages/core/src/components/modal-header/modal-header.tsx
@@ -38,7 +38,7 @@ export class ModalHeader {
   /**
    * Icon of the Header
    */
-  @Prop() icon: string;
+  @Prop() icon?: string;
 
   @Watch('icon')
   onIconChange(icon: string) {
@@ -54,22 +54,24 @@ export class ModalHeader {
   /**
    * Icon color
    */
-  @Prop() iconColor: string;
+  @Prop() iconColor?: string;
 
   /**
    * Emits when close icon is clicked and closes the modal
    * Can be prevented, in which case only the event is triggered, and the modal remains open
    */
-  @Event() closeClick: EventEmitter<MouseEvent>;
+  @Event() closeClick!: EventEmitter<MouseEvent>;
 
-  private parentDialog: HTMLIxModalElement;
+  private parentDialog!: HTMLIxModalElement;
 
   componentDidLoad() {
     this.parentDialog = closestPassShadow(
       this.hostElement,
       'ix-modal'
     ) as HTMLIxModalElement;
-    this.onIconChange(this.icon);
+    if (this.icon) {
+      this.onIconChange(this.icon!);
+    }
   }
 
   private onCloseClick(event: MouseEvent) {

diff --git a/packages/core/src/tests/application/application.e2e.ts b/packages/core/src/tests/application/application.e2e.ts
@@ -245,8 +245,9 @@ regressionTest.describe('application-switch', () => {
 });
 
 Object.keys(viewPorts).forEach((viewPort) => {
+  type ViewPortKey = keyof typeof viewPorts;
   regressionTest(`MenuSidebar ${viewPort}`, async ({ page }) => {
-    await page.setViewportSize(viewPorts[viewPort]);
+    await page.setViewportSize(viewPorts[viewPort as ViewPortKey]);
     await page.goto('application/application-switch');
 
     const toggleMenuButton = page.locator('ix-menu-expand-icon').nth(0);