-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/menu): rework of menu #592
Conversation
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration guide recommendations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor change then I will accept LOL
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the new behavior?
ix-menu
Item dropdown overflow is removed
We replaced the overflow menu with second level navigation in form of categories
If the menu stills overflow the bottom of the menu a scroll container will be displayed.
Multiple screen layouts
The
ix-basic-navigation
in combination of theix-menu
comes with 3 layout formats:You can force the old behavior by setting the
supportedModes
to['small', 'medium']
e.gix-menu-about and ix-menu-settings
Event changed from
CustomEvent<PointerEvent>
toCustomEvent<{ nativeEvent: MouseEvent, name: string }}>
Does this introduce a breaking change?