Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/icon-button): deprecated size 32 #620

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

[IX-137]

What is the new behavior?

  • Added icon-button deprecated message for size 32 on icon-button

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the Documentation Improvements or additions to documentation label Jul 17, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jul 17, 2023
@danielleroux danielleroux merged commit e989be5 into main Jul 17, 2023
@danielleroux danielleroux deleted the fix/icon-button branch July 17, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants