Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/icon-button): deprecated size 32 #620

Merged
merged 3 commits into from
Jul 17, 2023
Merged

fix(core/icon-button): deprecated size 32 #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86294cf
fix: deprecate size 32
goncalosard Jul 5, 2023
db1dbf5
fix: deprecated 3.0.0
goncalosard Jul 6, 2023
04f67c4
Merge branch 'main' of https://github.com/siemens/ix into fix/icon-bu…
goncalosard Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/core/component-doc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5263,8 +5263,14 @@
"attr": "size",
"reflectToAttr": false,
"docs": "Size of icon in button",
"docsTags": [],
"docsTags": [
{
"name": "deprecated",
"text": "Only size 32 will be removed in 3.0.0"
}
],
"default": "'24'",
"deprecation": "Only size 32 will be removed in 3.0.0",
"values": [
{
"value": "12",
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,7 @@ export namespace Components {
"selected": boolean;
/**
* Size of icon in button
* @deprecated Only size 32 will be removed in 3.0.0
*/
"size": '32' | '24' | '16' | '12';
/**
Expand Down Expand Up @@ -3867,6 +3868,7 @@ declare namespace LocalJSX {
"selected"?: boolean;
/**
* Size of icon in button
* @deprecated Only size 32 will be removed in 3.0.0
*/
"size"?: '32' | '24' | '16' | '12';
/**
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/components/icon-button/icon-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ export class IconButton implements Button {

/**
* Size of icon in button
*
* @deprecated Only size 32 will be removed in 3.0.0
*/
@Prop() size: '32' | '24' | '16' | '12' = '24';

Expand Down