Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic content for modals #700

Closed
katjaKoppensteiner opened this issue Aug 16, 2023 · 0 comments · Fixed by #714
Closed

Dynamic content for modals #700

katjaKoppensteiner opened this issue Aug 16, 2023 · 0 comments · Fixed by #714
Labels
triage We discuss this topic in our internal weekly

Comments

@katjaKoppensteiner
Copy link
Collaborator

What happened?

The modal is not able to handle dynamic content.

We are using Reactive Forms inside of the modal and we have to enable/disable the save button depending if the form is valid or not.
We are doing this with a simple @input but it does never change the active state of the button. I have highlighted the respective lines in the screenshots below:
MicrosoftTeams-image (17)
MicrosoftTeams-image (18)

Here you can see, within the console the value of the input changes accordingly, but the HTML is not re-rendered (next to the save button it is still true instead of false)
MicrosoftTeams-image (16)

The Modal is quite complicated to be used, we didn't get it why a ModalService is needed for handling all of the stuff. It would be much easier without the ModalService and without the ViewChild. We got a lot of restrictions and had to modify the code a lot to be able to use it.

Custom code examples:

  • Positioning is currently only able to be Centered, we also need it at the bottom right corner -> there I used the modalDialogClass property
  • Available sizes for the modal are strange, we need more possible sizes than SM, LG or XL -> there I used the modalDialogClass property
  • modalDialogClass property is not able to handle spacings -> if you have to add more than one class (depending on the inputs) you might have "classA classB classC" -> the whole ModalService breaks

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

v1.4.0

Code to produce this issue.

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage We discuss this topic in our internal weekly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant