Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IxSelect]: Support for Angular Forms #738

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Tiagogv
Copy link
Contributor

@Tiagogv Tiagogv commented Sep 5, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: closes #736

What is the new behavior?

  • Added valueAccessorConfigs for ix-select to angular output target
  • Change selectedIndices to value in order to work with Stencil's generated ValueAccessor. Backward compatibility was added. Deprecated selectedIndices.
  • Change itemSelectionChange to valueChange (Backward compatibility added). valueChange now emits a single value if mode='single' and an array if mode='multiple'. This is more close aligned with the default behavior of a native select element. Deprecated itemSelectionChange.

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • Tested the generated angular component with [ngModel].
  • Tested the web component to make sure behavior did not changed in all modes ('single', 'multiple' and 'editable')

Other information

@danielleroux danielleroux added this to the 2.0.0 milestone Sep 6, 2023
@danielleroux danielleroux merged commit c0bb78f into siemens:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IxSelect] Support for Angular Forms
3 participants