-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/menu-category): fix unwanted behavior with active element #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleroux
changed the title
fix(core/897-menu): fix unwanted behavior with active element
fix(core/menu-category): fix unwanted behavior with active element
Feb 21, 2024
nuke-ellington
requested changes
Feb 22, 2024
packages/core/src/components/menu-category/test/menu-category.ct.ts
Outdated
Show resolved
Hide resolved
nuke-ellington
previously approved these changes
Feb 23, 2024
danielleroux
previously approved these changes
Feb 26, 2024
# Conflicts: # packages/core/src/tests/menu/basic/index.html # packages/core/src/tests/menu/menu.e2e.ts
matthiashader
dismissed stale reviews from nuke-ellington and danielleroux
via
February 26, 2024 07:30
0a7b22c
danielleroux
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Upon reopening the ix-menu, the ix-category appears expanded but contains no items. Only after collapsing and reopening the ix-menu-category, the menu-items become visible again.
Found a small edge case, where the category does not initially open when the menu is expanded
What is the new behavior?
Does this introduce a breaking change?
Testing
Other information