-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(date-dropdown): updated the current date when the props are changed #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this breaks a unit test. Also a test case for the change was not added.
bf36bc4
to
500b5fd
Compare
Hi @nuke-ellington , |
@ridvandmrc Do you plan to update this PR? Regarding @nuke-ellington change request? There are also some debug console log statements inside the component code, you should remove the logs there. |
Yes, I plan to update, and I remove every logs |
500b5fd
to
303e39b
Compare
🦋 Changeset detectedLatest commit: 4a1d6d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @danielleroux , |
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
date-dropdown can not be set outside of the component
GitHub Issue Number: #1122
What is the new behavior?
Fixed and tested
Does this introduce a breaking change?
Testing
Other information