Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce bundle size in combination with icons #1238

Merged
merged 19 commits into from
Jul 29, 2024

Conversation

danielleroux
Copy link
Collaborator

🆕 What is the new behavior?

  • Naming imports like ` are not supported any more. (Reducing bundle size and chunk loading)
  • Naming imports like <ix-icon name="star"></ix-icon> requires a additional configuration entry inside the angular.json. (or similar entry for none angular projects)

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: f584232

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@siemens/ix-angular Major
@siemens/ix-aggrid Major
@siemens/ix-react Major
@siemens/ix Major
@siemens/ix-vue Major
@siemens/ix-echarts Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux changed the base branch from v3 to release-3.0.0 June 14, 2024 11:37
danielleroux and others added 7 commits July 10, 2024 08:28
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Copy link
Contributor

github-actions bot commented Jul 10, 2024

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

You decreased the total number of errors in PR branch by 3 🎉

ESLint check

Total ESLint warnings are the same in both branches

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some TODO sections in the BREAKING_CHANGES.md file. Let's not forget to remove them :)

@danielleroux danielleroux merged commit 8803f31 into release-3.0.0 Jul 29, 2024
16 checks passed
@danielleroux danielleroux deleted the v3-icon-performance branch July 29, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants