Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): provide angular standalone components #1325

Merged
merged 53 commits into from
Sep 4, 2024

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jun 14, 2024

🆕 What is the new behavior?

  • Update ix-angular to latest LTS version v17
  • Add basic support for angular standalone components
  • Integrate v3 icons (snapshot build)
  • Update breaking changes guideline

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 493a077

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-angular Major
@siemens/ix Major
@siemens/ix-react Major
@siemens/ix-vue Major
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux changed the base branch from main to release-3.0.0 June 14, 2024 11:44
Copy link
Contributor

github-actions bot commented Jul 10, 2024

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

😢 Total errors increased in PR branch: 6

Increased errors in PR branch: src/components/menu-item/menu-item.tsx - 9 errors
  • src/components/menu-item/menu-item.tsx:40:11

    • Property 'label' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:59:28

    • Property 'tabIcon' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:64:28

    • Property 'icon' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:69:11

    • Property 'notifications' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:74:11

    • Property 'active' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:79:11

    • Property 'disabled' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:82:11

    • Property 'isCategory' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:84:14

    • Property 'hostElement' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:86:12

    • Property 'tooltip' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:87:12

    • Property 'menuExpanded' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:91:11

    • Property 'menuExpandedDisposer' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-item/menu-item.tsx:104:25

    • 'menuController.nativeElement' is possibly 'null'.

ESLint check

😢 Total ESLint warnings increased in PR branch: 2

ESLint warnings
  • /packages/core/src/components/application-header/test/application-header.ct.ts:57:56

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/application-header/test/application-header.ct.ts:117:58

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/application-header/test/application-header.ct.ts:179:58

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/application-header/test/application-header.ct.ts:206:17

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/application-header/test/application-header.ct.ts:249:58

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/application-header/test/application-header.ct.ts:274:17

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/application-header/test/application-header.ct.ts:302:17

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/breadcrumb-item/breadcrumb-item.tsx:52:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/breadcrumb-item/breadcrumb-item.tsx:55:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/breadcrumb-item/breadcrumb-item.tsx:58:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/breadcrumb-item/breadcrumb-item.tsx:66:18

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/category-filter/category-filter.tsx:125:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/category-filter/category-filter.tsx:130:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/chip/chip.tsx:46:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/date-dropdown/test/date-dropdown.ct.ts:161:28

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/date-dropdown/test/date-dropdown.ct.ts:162:57

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/date-picker/date-picker.tsx:62:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/date-picker/date-picker.tsx:163:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/date-picker/date-picker.tsx:175:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/date-picker/date-picker.tsx:570:39

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/date-picker/date-picker.tsx:644:26

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/drawer/drawer.tsx:37:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/drawer/drawer.tsx:106:31

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/group/group.tsx:53:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/map-navigation/map-navigation.tsx:50:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/menu/menu.tsx:61:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/message-bar/message-bar.tsx:42:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/pagination/pagination.tsx:69:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/select/select.tsx:477:33

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/select/select.tsx:518:30

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/time-picker/time-picker.tsx:61:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/time-picker/time-picker.tsx:66:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/time-picker/time-picker.tsx:71:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/time-picker/time-picker.tsx:76:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/time-picker/time-picker.tsx:81:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/time-picker/time-picker.tsx:291:35

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/toast/toast.tsx:53:3

    • Boolean properties decorated with @prop() should default to false
  • /packages/core/src/components/upload/upload.tsx:136:34

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/upload/upload.tsx:207:31

    • Unexpected any. Specify a different type.
  • /packages/core/src/components/utils/context.ts:117:61

    • Unexpected any. Specify a different type.
  • /packages/core/src/tests/utils/test/page.ts:25:22

    • Unexpected any. Specify a different type.
  • /packages/core/src/tests/utils/test/page.ts:77:18

    • Unexpected any. Specify a different type.

@danielleroux danielleroux marked this pull request as ready for review August 28, 2024 13:13
matthiashader
matthiashader previously approved these changes Sep 4, 2024
danielleroux and others added 3 commits September 4, 2024 15:56
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@danielleroux danielleroux merged commit 71411db into release-3.0.0 Sep 4, 2024
16 checks passed
@danielleroux danielleroux deleted the v3-angular-standalone branch September 4, 2024 14:30
@danielleroux danielleroux mentioned this pull request Jan 17, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants