Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): remove commonjs #1328

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

danielleroux
Copy link
Collaborator

💡 What is the current behavior?

GitHub Issue Number: #1123

🆕 What is the new behavior?

  • Remove commonjs from @siemens/ix-vue

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: f2e1e43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix-vue Major
@siemens/ix Major
@siemens/ix-angular Major
@siemens/ix-react Major
@siemens/ix-aggrid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux merged commit c17750d into release-3.0.0 Jun 14, 2024
10 checks passed
@danielleroux danielleroux deleted the v3-remove-commonjs-vue branch June 14, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants