Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/dropdown): clean up disconnected dropdowns #1483

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Sep 17, 2024

💡 What is the current behavior?

GitHub Issue Number: #IX-1709

🆕 What is the new behavior?

  • If a dropdown disconnects it does not clean up the submenu IDs in the controller
  • This will lead to a NPE the next time the controller tries to dispose the dropdown

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: ee0e0b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@danielleroux danielleroux merged commit a0316f5 into main Sep 23, 2024
12 checks passed
@danielleroux danielleroux deleted the fix/1709-dropdown-in-tab branch September 23, 2024 10:38
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants