Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/content-header): adapt spacing #1514

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

matthiashader
Copy link
Collaborator

💡 What is the current behavior?

  • primary -> subtitle-padding: 8px
  • secondary -> No padding in the title

GitHub Issue Number: N/A, IX-1581

🆕 What is the new behavior?

  • primary -> subtitle-padding: 0px
  • secondary -> padding-top 4px, padding-bottom 4px

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: a416077

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@danielleroux danielleroux merged commit 60760bc into main Oct 16, 2024
15 checks passed
@danielleroux danielleroux deleted the fix/1581-content-header branch October 16, 2024 11:21
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants