Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated docs #1547

Merged
merged 18 commits into from
Nov 6, 2024
Merged

Deprecated docs #1547

merged 18 commits into from
Nov 6, 2024

Conversation

AndreasBerliner
Copy link
Collaborator

@AndreasBerliner AndreasBerliner commented Oct 30, 2024

💡 What is the current behavior?

Deprecated pages are shown together with current docs.

GitHub Issue Number: n.A. [IX-1326]

🆕 What is the new behavior?

  • Move deprecated docs from current documents to separate directory
  • Add solution to navigate to deprecated docs from current version and provide info about deprecation
component description
input Most basic functionality, old browser tab remains open, back to basic old component
textarea Deprecate, new web component existing
radiobutton Deprecate, new web component existing
checkbox Deprecate, do the groups remain in the components page (clarify!)?
select Usage the same, only "forms-ready" -> left as it is
toggle Usage the same, only "forms-ready" -> left as it is
radio-group Remains as described above
checkbox-group Remains as described above

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 76695a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AndreasBerliner AndreasBerliner changed the base branch from main to feat/select-validation October 30, 2024 09:53
Copy link
Contributor

Report of strict check

src/components/date-dropdown/date-dropdown.tsx
  • src/components/date-dropdown/date-dropdown.tsx(48,14): error TS2564: Property 'hostElement' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'hostElement' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(74,11): error TS2564: Property 'from' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'from' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(82,11): error TS2564: Property 'to' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'to' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(88,11): error TS2564: Property 'minDate' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'minDate' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(94,11): error TS2564: Property 'maxDate' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'maxDate' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(167,20): error TS2564: Property 'dateRangeChange' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'dateRangeChange' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(169,20): error TS2564: Property 'selectedDateRangeId' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'selectedDateRangeId' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(170,20): error TS2564: Property 'currentRangeValue' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'currentRangeValue' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(175,20): error TS2564: Property 'triggerRef' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'triggerRef' has no initializer and is not definitely assigned in the constructor.
  • src/components/date-dropdown/date-dropdown.tsx(262,5): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/date-dropdown/date-dropdown.tsx(262,5): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/date-dropdown/date-dropdown.tsx(306,26): error TS2322: Type 'HTMLIxButtonElement | undefined' is not assignable to type 'HTMLElement'.: error TS2322: Type 'HTMLIxButtonElement | undefined' is not assignable to type 'HTMLElement'.
src/components/dropdown/dropdown-controller.ts
  • src/components/dropdown/dropdown-controller.ts(34,3): error TS2322: Type 'unknown' is not assignable to type 'boolean'.: error TS2322: Type 'unknown' is not assignable to type 'boolean'.
  • src/components/dropdown/dropdown-controller.ts(98,34): error TS2722: Cannot invoke an object which is possibly 'undefined'.: error TS2722: Cannot invoke an object which is possibly 'undefined'.
  • src/components/dropdown/dropdown-controller.ts(98,34): error TS18048: 'dropdown.willPresent' is possibly 'undefined'.: error TS18048: 'dropdown.willPresent' is possibly 'undefined'.
  • src/components/dropdown/dropdown-controller.ts(107,20): error TS2345: Argument of type 'DropdownInterface | undefined' is not assignable to parameter of type 'DropdownInterface'.: error TS2345: Argument of type 'DropdownInterface | undefined' is not assignable to parameter of type 'DropdownInterface'.
  • src/components/dropdown/dropdown-controller.ts(112,33): error TS2722: Cannot invoke an object which is possibly 'undefined'.: error TS2722: Cannot invoke an object which is possibly 'undefined'.
  • src/components/dropdown/dropdown-controller.ts(112,33): error TS18048: 'dropdown.willDismiss' is possibly 'undefined'.: error TS18048: 'dropdown.willDismiss' is possibly 'undefined'.
  • src/components/dropdown/dropdown-controller.ts(182,7): error TS2769: No overload matches this call.: error TS2769: No overload matches this call.
  • src/components/dropdown/dropdown-controller.ts(203,38): error TS2769: No overload matches this call.: error TS2769: No overload matches this call.
src/components/dropdown/dropdown.tsx
  • src/components/dropdown/dropdown.tsx(68,11): error TS2564: Property 'trigger' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'trigger' has no initializer and is not definitely assigned in the constructor.
  • src/components/dropdown/dropdown.tsx(73,11): error TS2564: Property 'anchor' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'anchor' has no initializer and is not definitely assigned in the constructor.
  • src/components/dropdown/dropdown.tsx(101,11): error TS2564: Property 'offset' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'offset' has no initializer and is not definitely assigned in the constructor.
  • src/components/dropdown/dropdown.tsx(110,11): error TS2564: Property 'overwriteDropdownStyle' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'overwriteDropdownStyle' has no initializer and is not definitely assigned in the constructor.
  • src/components/dropdown/dropdown.tsx(131,12): error TS2564: Property 'showChanged' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'showChanged' has no initializer and is not definitely assigned in the constructor.
  • src/components/dropdown/dropdown.tsx(133,11): error TS2322: Type 'null' is not assignable to type '() => void'.: error TS2322: Type 'null' is not assignable to type '() => void'.
  • src/components/dropdown/dropdown.tsx(138,11): error TS2564: Property 'dropdownRef' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'dropdownRef' has no initializer and is not definitely assigned in the constructor.
  • src/components/dropdown/dropdown.tsx(142,11): error TS2564: Property 'arrowFocusController' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'arrowFocusController' has no initializer and is not definitely assigned in the constructor.
  • src/components/dropdown/dropdown.tsx(221,12): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/dropdown/dropdown.tsx(242,7): error TS2345: Argument of type 'Element | undefined' is not assignable to parameter of type 'Element | Document | Window'.: error TS2345: Argument of type 'Element | undefined' is not assignable to parameter of type 'Element | Document | Window'.
  • src/components/dropdown/dropdown.tsx(278,7): error TS2345: Argument of type '(event: KeyboardEvent) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject'.: error TS2345: Argument of type '(event: KeyboardEvent) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject'.
  • src/components/dropdown/dropdown.tsx(299,5): error TS2322: Type 'Element | null' is not assignable to type 'Element | undefined'.: error TS2322: Type 'Element | null' is not assignable to type 'Element | undefined'.
  • src/components/dropdown/dropdown.tsx(345,7): error TS2322: Type 'undefined' is not assignable to type 'Promise<Element>'.: error TS2322: Type 'undefined' is not assignable to type 'Promise<Element>'.
  • src/components/dropdown/dropdown.tsx(351,24): error TS2345: Argument of type 'Element | null' is not assignable to parameter of type 'Element | PromiseLike<Element>'.: error TS2345: Argument of type 'Element | null' is not assignable to parameter of type 'Element | PromiseLike<Element>'.
  • src/components/dropdown/dropdown.tsx(356,19): error TS2345: Argument of type 'Element | null' is not assignable to parameter of type 'Element | PromiseLike<Element>'.: error TS2345: Argument of type 'Element | null' is not assignable to parameter of type 'Element | PromiseLike<Element>'.
  • src/components/dropdown/dropdown.tsx(371,7): error TS2322: Type 'Element | null' is not assignable to type 'Element | undefined'.: error TS2322: Type 'Element | null' is not assignable to type 'Element | undefined'.
  • src/components/dropdown/dropdown.tsx(407,7): error TS2322: Type 'null' is not assignable to type '() => void'.: error TS2322: Type 'null' is not assignable to type '() => void'.
  • src/components/dropdown/dropdown.tsx(439,7): error TS18048: 'positionConfig.middleware' is possibly 'undefined'.: error TS18048: 'positionConfig.middleware' is possibly 'undefined'.
  • src/components/dropdown/dropdown.tsx(447,10): error TS2488: Type '(false | { name: string; options?: any; fn: (state: { placement: Placement; platform: Platform; strategy: Strategy; x: number; y: number; initialPlacement: Placement; middlewareData: MiddlewareData; rects: ElementRects; elements: Elements; }) => Promisable<...>; } | null | undefined)[] | undefined' must have a '[Symbol.iterator]()' method that returns an iterator.: error TS2488: Type '(false | { name: string; options?: any; fn: (state: { placement: Placement; platform: Platform; strategy: Strategy; x: number; y: number; initialPlacement: Placement; middlewareData: MiddlewareData; rects: ElementRects; elements: Elements; }) => Promisable<...>; } | null | undefined)[] | undefined' must have a '[Symbol.iterator]()' method that returns an iterator.
  • src/components/dropdown/dropdown.tsx(463,11): error TS2345: Argument of type 'Element | undefined' is not assignable to parameter of type 'ReferenceElement'.: error TS2345: Argument of type 'Element | undefined' is not assignable to parameter of type 'ReferenceElement'.
  • src/components/dropdown/dropdown.tsx(493,7): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/dropdown/dropdown.tsx(493,7): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/dropdown/dropdown.tsx(503,5): error TS2322: Type 'Element | null' is not assignable to type 'Element | undefined'.: error TS2322: Type 'Element | null' is not assignable to type 'Element | undefined'.
  • src/components/dropdown/dropdown.tsx(552,24): error TS2322: Type 'HTMLElement | null' is not assignable to type 'HTMLElement'.: error TS2322: Type 'HTMLElement | null' is not assignable to type 'HTMLElement'.
src/components/select/select.tsx
  • src/components/select/select.tsx(466,37): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.: error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.

@matthiashader matthiashader added the Deploy Preview Deploy a preview instance of the documentation label Oct 31, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Deploy Preview for industrial-experience ready!

Name Link
🔍 Latest deploy log https://app.netlify.com/sites/industrial-experience/deploys/6728da6a7c40dea79e8148e7
😎 Deploy Preview https://pr-preview-1547--industrial-experience.netlify.app

# Conflicts:
#	packages/documentation/docs/controls/_number-input_styleguide.mdx
#	packages/documentation/docs/controls/_select_styleguide.md
#	packages/documentation/docs/controls/_textarea-field_styleguide.mdx
Copy link

sonarqubecloud bot commented Nov 6, 2024

@danielleroux danielleroux merged commit 434d1a5 into feat/select-validation Nov 6, 2024
12 checks passed
@danielleroux danielleroux deleted the deprecated-docs branch November 6, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deploy Preview Deploy a preview instance of the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants