Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/tooltip|dropdown): find trigger if in same shadow DOM #1560

Merged
merged 19 commits into from
Nov 25, 2024

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Nov 12, 2024

💡 What is the current behavior?

GitHub Issue Number: Closes #1530, [IX-1885]

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: b987358

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nuke-ellington nuke-ellington marked this pull request as draft November 19, 2024 14:58
@nuke-ellington nuke-ellington marked this pull request as ready for review November 20, 2024 09:11
Copy link
Collaborator

@matthiashader matthiashader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset missing & strict typing (if its necessary inside an unit test)

matthiashader
matthiashader previously approved these changes Nov 21, 2024
@danielleroux danielleroux merged commit d7e9777 into main Nov 25, 2024
3 checks passed
@danielleroux danielleroux deleted the fix/1885-tooltip-shadow-dom branch November 25, 2024 10:12
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip not working with shadowDOM
4 participants