Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt documentation new #1569

Merged
merged 26 commits into from
Nov 21, 2024
Merged

Conversation

AndreasBerliner
Copy link
Collaborator

@AndreasBerliner AndreasBerliner commented Nov 20, 2024

💡 What is the current behavior?

GitHub Issue Number: #

🆕 What is the new behavior?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: dcb6aeb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Report of strict check

src/components/date-dropdown/date-dropdown.tsx
  • src/components/date-dropdown/date-dropdown.tsx(191,20): error TS2564: Property 'selectedDateRangeId' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'selectedDateRangeId' has no initializer and is not definitely assigned in the constructor.
src/components/select/select.tsx
  • src/components/select/select.tsx(308,9): error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'HTMLElement'.: error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'HTMLElement'.
  • src/components/select/select.tsx(314,33): error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'Node'.: error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'Node'.
  • src/components/select/select.tsx(359,5): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.
  • src/components/select/select.tsx(405,5): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/select/select.tsx(452,5): error TS2322: Type '(string | undefined)[]' is not assignable to type 'string[]'.: error TS2322: Type '(string | undefined)[]' is not assignable to type 'string[]'.
  • src/components/select/select.tsx(471,37): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.: error TS2345: Argument of type 'null' is not assignable to parameter of type 'string[] | undefined'.
  • src/components/select/select.tsx(522,7): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.
  • src/components/select/select.tsx(556,24): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.: error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  • src/components/select/select.tsx(625,7): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/select/select.tsx(700,12): error TS18048: 'item.label' is possibly 'undefined'.: error TS18048: 'item.label' is possibly 'undefined'.
  • src/components/select/select.tsx(804,5): error TS2322: Type 'Promise<HTMLInputElement | undefined>' is not assignable to type 'Promise<HTMLInputElement>'.: error TS2322: Type 'Promise<HTMLInputElement | undefined>' is not assignable to type 'Promise<HTMLInputElement>'.
  • src/components/select/select.tsx(883,23): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.

@AndreasBerliner AndreasBerliner changed the base branch from main to feat/select-validation November 20, 2024 12:31
@danielleroux danielleroux marked this pull request as ready for review November 21, 2024 08:14
@danielleroux danielleroux merged commit 7cf097d into feat/select-validation Nov 21, 2024
6 checks passed
@danielleroux danielleroux deleted the adapt-documentation-new branch November 21, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants