Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove bootstrap as dependency #1578

Merged
merged 31 commits into from
Jan 24, 2025
Merged

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Nov 26, 2024

🆕 What is the new behavior?

Remove bootstrap dependencies

Points to clarify:

  • Should we introduce .h1 - .h6 utility css classes? (.typography-h1 already exist)
  • Update snapshots
  • Add snapshot test which imports bootstrap as dependency

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 353136e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Major
@siemens/ix-aggrid Patch
@siemens/ix-angular Major
@siemens/ix-react Major
@siemens/ix-vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux marked this pull request as draft November 26, 2024 11:07
@danielleroux danielleroux changed the base branch from main to release-3.0.0 January 14, 2025 07:59
@siemens siemens deleted a comment from sonarqubecloud bot Jan 14, 2025
@danielleroux danielleroux marked this pull request as ready for review January 21, 2025 08:38
@danielleroux danielleroux changed the title V3 remove bootstrap feat: remove bootstrap as dependency Jan 23, 2025
@siemens siemens deleted a comment from github-actions bot Jan 23, 2025
Copy link

@danielleroux danielleroux merged commit dd8b3eb into release-3.0.0 Jan 24, 2025
15 checks passed
@danielleroux danielleroux deleted the v3-remove-bootstrap branch January 24, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants