Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/button): add autofocus property #1588

Merged
merged 12 commits into from
Dec 6, 2024

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Nov 29, 2024

💡 What is the current behavior?

GitHub Issue Number: IX-1886 / closes #1531

🆕 What is the new behavior?

  • Buttons can now have autofocus
  • Modals can now automatically set focus on nested buttons

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: ba31212

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Report of strict check

src/components/utils/modal/modal.ts
  • src/components/utils/modal/modal.ts(118,30): error TS18048: 'dialogRef' is possibly 'undefined'.: error TS18048: 'dialogRef' is possibly 'undefined'.

@danielleroux danielleroux merged commit 1c65a17 into main Dec 6, 2024
16 checks passed
@danielleroux danielleroux deleted the feat/1886-button-autofocus branch December 6, 2024 07:19
This was referenced Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow programmatic focus and focus the first focussable nested element in a modal
2 participants