Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/message-bar): add new message-bar types #1737

Merged
merged 5 commits into from
Mar 4, 2025

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Mar 3, 2025

💡 What is the current behavior?

  • current available types: danger, warning, info

GitHub Issue Number: #N/A, [IX-363]

🆕 What is the new behavior?

  • Newly added types: critical, success, neutral, primary

❓ Open Questions

  • should we rename "danger" to "alarm"
  • should we add an "alarm" type (and remove the "danger" in 3.0?)
  • redo documentation, specifically split variants apart?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: 5ac0767

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Minor
@siemens/ix-aggrid Patch
@siemens/ix-angular Minor
@siemens/ix-react Minor
@siemens/ix-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft March 3, 2025 07:54
@matthiashader matthiashader marked this pull request as ready for review March 3, 2025 10:40
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nuke-ellington nuke-ellington merged commit 149dfbd into main Mar 4, 2025
15 checks passed
@nuke-ellington nuke-ellington deleted the feat/363-message-bar branch March 4, 2025 11:21
This was referenced Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants