Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add global namespace to input element #1758

Merged
merged 22 commits into from
Mar 12, 2025

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Mar 7, 2025

💡 What is the current behavior?

GitHub Issue Number: Fixes #1398 ref IX-1503

🆕 What is the new behavior?

  • Add namespace to input, textarea and label
  • Change default width from 100% to auto
  • Update visual regression tests
  • Revert changed playwright config

//Udate

  • Add prefix to .table class

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: 0825907

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@siemens/ix Major
@siemens/ix-aggrid Patch
@siemens/ix-angular Major
@siemens/ix-react Major
@siemens/ix-vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielleroux danielleroux changed the base branch from main to release-3.0.0 March 7, 2025 16:07
@danielleroux danielleroux force-pushed the fix/input-namespacing branch from 21764cb to ac582d4 Compare March 10, 2025 10:18
Copy link

@danielleroux danielleroux merged commit b062ebf into release-3.0.0 Mar 12, 2025
15 checks passed
@danielleroux danielleroux deleted the fix/input-namespacing branch March 12, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IX css is affecting non-ix components
2 participants