-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/workflow-steps): onStepSelected event #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test case missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix not working:
<ix-workflow-steps
onStepSelected={(event) => {
console.log(event.detail);
}}
>
<ix-workflow-step>Step 0</ix-workflow-step>
<ix-workflow-step>Step 1</ix-workflow-step>
<ix-workflow-step>Step 2</ix-workflow-step>
</ix-workflow-steps>
Should print the index of the step.
…m/siemens/ix into fix/workflow-steps-onstepselected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change - lgtm otherwise
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
[IX-314]
What is the new behavior?
Does this introduce a breaking change?