Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support xz compressed images #121

Closed
chombourger opened this issue Dec 23, 2021 · 8 comments · Fixed by #153
Closed

support xz compressed images #121

chombourger opened this issue Dec 23, 2021 · 8 comments · Fixed by #153
Assignees
Milestone

Comments

@chombourger
Copy link
Collaborator

use https://github.com/Rogdham/python-xz to support .xz images

@vj-kumar
Copy link
Contributor

vj-kumar commented Jan 2, 2022

Not sure if someone is looking into to it. If not planing to take it.

@chombourger
Copy link
Collaborator Author

Not sure if someone is looking into to it. If not planing to take it.

Thanks!

@vj-kumar
Copy link
Contributor

vj-kumar commented Jan 2, 2022

@chombourger Any specific reason for using python-xz? Looks like lzma can do it too. I do see some benefits mentioned in python-xz, but currently not sure whether it will have an impact.

@jan-kiszka
Copy link
Contributor

If you are talking about isar image compression: Adriaan has started porting over the OE image compression features. That will obsolete the currently needed custom image classes.

@vj-kumar
Copy link
Contributor

vj-kumar commented Jan 2, 2022

@jan-kiszka This is about mtda's storage writer supporting xz compressed images.

compression = CONSTS.IMAGE(compression)
if compression == CONSTS.IMAGE.RAW:
self._write = self.write_raw
elif compression == CONSTS.IMAGE.BZ2:
self._write = self.write_bz2
elif compression == CONSTS.IMAGE.GZ:
self._write = self.write_gz
elif compression == CONSTS.IMAGE.ZST:
self._write = self.write_zst
else:
raise ValueError("unsupported image compression!")
self._compression = compression

@chombourger chombourger added this to the 0.15 milestone Jan 4, 2022
@vj-kumar
Copy link
Contributor

vj-kumar commented Jan 8, 2022

Bz2 write is broken. Tested in Qemu, Richa also validated in an actual board. XZ similar implementation to BZ2 also doesnot work. Checking.

@chombourger
Copy link
Collaborator Author

Thanks for the info. We will get a framework to test our APIs and features With #146 and hopefully avoid regressions in the future

@vj-kumar
Copy link
Contributor

Related to #147

Planning to address #147 before getting here.

vj-kumar added a commit to vj-kumar/mtda that referenced this issue Jan 12, 2022
Based on bz2 logic.

Closes: siemens#121

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
vj-kumar added a commit to vj-kumar/mtda that referenced this issue Jan 12, 2022
Based on bz2 logic.

Closes: siemens#121

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
chombourger pushed a commit that referenced this issue Jan 12, 2022
Based on bz2 logic.

Closes: #121

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants