Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull debian 11.1 version instead of pulling all debian versions #194

Closed
wants to merge 1 commit into from
Closed

pull debian 11.1 version instead of pulling all debian versions #194

wants to merge 1 commit into from

Conversation

boksheos
Copy link

@boksheos boksheos commented Feb 4, 2022

Signed-off-by: Onkar Bokshe OnkarSurendrakumar_Bokshe@mentor.com

vj-kumar
vj-kumar reviewed Feb 4, 2022
View reviewed changes
configs/docker.ini Outdated
@@ -34,7 +34,7 @@ variant=docker
# ---------------------------------------------------------------------------
[power]
variant=docker
image=debian
image=debian:11.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does specifying just debian pulling all versions of debian?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vj-kumar yes while testing i observed that it was pulling all debian version even the older versions too. this hangs our mtda service and not able to use any of the mtda commands.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truly hang? if you do not have the specified image already downloaded then it will be pulled and that could take some time depending on your network load / speed

@chombourger
Copy link
Collaborator

commit log should be prefixed with docker:
I would then like to understand the motivation for this change?
docker pull debian would pull the latest Debian image (and only that one)
Are we wanting to pull 11.1 specifically to make sure people use a version we have tested?

@chombourger chombourger self-requested a review February 4, 2022 08:05
@boksheos
Copy link
Author

boksheos commented Feb 4, 2022

@chombourger docker pull debian pulls all the versions of debian hence we have mentioned latest version and it is tested working fine.

@boksheos
Copy link
Author

boksheos commented Feb 4, 2022

added prefix docker: to commit.

@boksheos boksheos requested a review from vj-kumar February 4, 2022 08:07
@vj-kumar
Copy link
Contributor

vj-kumar commented Feb 4, 2022

BTW, 11.2 is the latest version.

@boksheos
Copy link
Author

boksheos commented Feb 4, 2022

BTW, 11.2 is the latest version.

updated to 11.2

@chombourger
Copy link
Collaborator

BTW, 11.2 is the latest version.

updated to 11.2

commit log still says 11.1 :)

docker: pull debian 11.2 version instead of pulling all debian versions
530549b 
Signed-off-by: Onkar Bokshe <OnkarSurendrakumar_Bokshe@mentor.com>
@boksheos
Copy link
Author

boksheos commented Feb 4, 2022

BTW, 11.2 is the latest version.

updated to 11.2

commit log still says 11.1 :)

updated to 11.2

@chombourger
Copy link
Collaborator

docker pull only pulls the latest version:

$ docker pull debian
Using default tag: latest
latest: Pulling from library/debian
0c6b8ff8c37e: Pull complete 
Digest: sha256:fb45fd4e25abe55a656ca69a7bef70e62099b8bb42a279a5e0ea4ae1ab410e0d
Status: Downloaded newer image for debian:latest
docker.io/library/debian:latest

(a single image was downloaded)

@boksheos
Copy link
Author

boksheos commented Feb 4, 2022

docker pull only pulls the latest version:

$ docker pull debian
Using default tag: latest
latest: Pulling from library/debian
0c6b8ff8c37e: Pull complete 
Digest: sha256:fb45fd4e25abe55a656ca69a7bef70e62099b8bb42a279a5e0ea4ae1ab410e0d
Status: Downloaded newer image for debian:latest
docker.io/library/debian:latest

(a single image was downloaded)

verified if we do not mention version it will install all version

onkar@onkarhome:~$ docker images
REPOSITORY TAG IMAGE ID CREATED SIZE
debian 10-slim 206294455d54 9 days ago 69.3MB
debian 10 f66b71803fa0 9 days ago 114MB
debian 11.2 04fbdaf87a6a 9 days ago 124MB
debian latest 04fbdaf87a6a 9 days ago 124MB
debian 11.1 05d2318291e3 2 months ago 124MB
ghcr.io/siemens/kas/kas-isar 2.6.3 1b2c79642b22 2 months ago 1.17GB
debian 10.1-slim 105ec214185d 2 years ago 69.2MB
debian 10.1 8e9f8546050d 2 years ago 114MB
debian 10.0-slim 83a10817c894 2 years ago 69.2MB
debian 10.0 85c4fd36a543 2 years ago 114MB

@chombourger
Copy link
Collaborator

docker pull only pulls the latest version:

$ docker pull debian
Using default tag: latest
latest: Pulling from library/debian
0c6b8ff8c37e: Pull complete 
Digest: sha256:fb45fd4e25abe55a656ca69a7bef70e62099b8bb42a279a5e0ea4ae1ab410e0d
Status: Downloaded newer image for debian:latest
docker.io/library/debian:latest

(a single image was downloaded)

verified if we do not mention version it will install all version

onkar@onkarhome:~$ docker images REPOSITORY TAG IMAGE ID CREATED SIZE debian 10-slim 206294455d54 9 days ago 69.3MB debian 10 f66b71803fa0 9 days ago 114MB debian 11.2 04fbdaf87a6a 9 days ago 124MB debian latest 04fbdaf87a6a 9 days ago 124MB debian 11.1 05d2318291e3 2 months ago 124MB ghcr.io/siemens/kas/kas-isar 2.6.3 1b2c79642b22 2 months ago 1.17GB debian 10.1-slim 105ec214185d 2 years ago 69.2MB debian 10.1 8e9f8546050d 2 years ago 114MB debian 10.0-slim 83a10817c894 2 years ago 69.2MB debian 10.0 85c4fd36a543 2 years ago 114MB

really strange. that's not what I am seeing here

@vj-kumar
Copy link
Contributor

vj-kumar commented Feb 4, 2022

docker has a -a option to pull all tags. Maybe that option is pulled from some place, like a config?

@chombourger
Copy link
Collaborator

docker has a -a option to pull all tags. Maybe that option is pulled from some place, like a config?

We don't use the docker CLI. I raised #197 just now to explicitly disable loading of all images. it would be good to check the version of python3-docker package used by QA. My system has 4.1.0-1.2

@vj-kumar
Copy link
Contributor

vj-kumar commented Feb 4, 2022

docker has a -a option to pull all tags. Maybe that option is pulled from some place, like a config?

We don't use the docker CLI. I raised #197 just now to explicitly disable loading of all images. it would be good to check the version of python3-docker package used by QA. My system has 4.1.0-1.2

Reproducible in my system.

Distro: Ubuntu 21.04 (Hirsute Hippo)
python3-docker version: 4.1.0-1.2

@chombourger
Copy link
Collaborator

docker has a -a option to pull all tags. Maybe that option is pulled from some place, like a config?

We don't use the docker CLI. I raised #197 just now to explicitly disable loading of all images. it would be good to check the version of python3-docker package used by QA. My system has 4.1.0-1.2

Reproducible in my system.

Distro: Ubuntu 21.04 (Hirsute Hippo) python3-docker version: 4.1.0-1.2

That's interesting. Let's see if #197 helps

@vj-kumar
Copy link
Contributor

vj-kumar commented Feb 4, 2022

docker has a -a option to pull all tags. Maybe that option is pulled from some place, like a config?

We don't use the docker CLI. I raised #197 just now to explicitly disable loading of all images. it would be good to check the version of python3-docker package used by QA. My system has 4.1.0-1.2

Reproducible in my system.
Distro: Ubuntu 21.04 (Hirsute Hippo) python3-docker version: 4.1.0-1.2

That's interesting. Let's see if #197 helps

It does not. Fix coming up.

@vj-kumar
Copy link
Contributor

vj-kumar commented Feb 4, 2022

#198 this should fix it. Tested with python3-docker version 4.1.0-1.2

@chombourger
Copy link
Collaborator

#198 this should fix it. Tested with python3-docker version 4.1.0-1.2

Great, thanks!

@chombourger chombourger closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chombourger chombourger Awaiting requested review from chombourger

@vj-kumar vj-kumar Awaiting requested review from vj-kumar

Assignees
No one assigned
Labels
check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boksheos @chombourger @vj-kumar