feat(www): preliminary support for uploading to the shared storage #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chombourger
force-pushed
the
www-upload
branch
from
1bd8a06 to
233f015
Compare
chombourger
force-pushed
the
www-upload
branch
from
233f015 to
21f8154
Compare
fmoessbauer
reviewed
Oct 7, 2024
| default: | ||
| storage_status.innerHTML = "unknown_document" | ||
| storage_status.title = "storage status unknown" | ||
| } | ||
| }); | ||
| const CHUNK_SIZE = 512 * 1024; |
There was a problem hiding this comment.
yes bytes. I need to test this feature a little more and in particular with large images. May even need to throttle the upload a bit as the browser will probably read the image much faster than we can write it. I have entered new territory while trying to implement this feature
Reworked a session handling code a bit and will now close the shared storage device if the owning session has vanished |
chombourger
force-pushed
the
www-upload
branch
from
e8fca6d to
825aa68
Compare
chombourger
force-pushed
the
www-upload
branch
from
825aa68 to
8d23c47
Compare
chombourger
force-pushed
the
www-upload
branch
from
8d23c47 to
9c77d05
Compare
chombourger
force-pushed
the
www-upload
branch
from
9c77d05 to
deb051c
Compare
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
Do not leave the shared storage device opened if the owning session has not interacted with us before the session timeout expired. Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
chombourger
force-pushed
the
www-upload
branch
from
deb051c to
c2ee066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.