Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaks found by goleak #36

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Fix leaks found by goleak #36

merged 3 commits into from
Aug 8, 2023

Conversation

michaeladler
Copy link
Member

Description

This fixes two leaks found by goleak:

  • the health checker was not shut down gracefully
  • in case of systemd socket-based activation, the created listeners were not closed

None of this is a real problem since the resources are cleaned up by the OS anyway, but fixing these allows us to enforce a zero leak policy via CI.

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

@michaeladler
fix: ensure health middleware gracefully shuts down
c6fd306 
Introduce a middleware shutdown mechanism and implement it for the
health middleware, ensuring it shuts down correctly when wfx terminates.

Signed-off-by: Michael Adler <michael.adler@siemens.com>
@michaeladler
fix: properly shutdown on socket-based activation
fab58c8 
Signed-off-by: Michael Adler <michael.adler@siemens.com>
@michaeladler
test: ensure there are no leaks
3942128 
This commit ensures that each package is tested for leaks.

Signed-off-by: Michael Adler <michael.adler@siemens.com>
@stormc stormc merged commit ecf9563 into siemens:main Aug 8, 2023
11 checks passed
@michaeladler michaeladler deleted the feat/goleak branch August 8, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormc stormc Awaiting requested review from stormc stormc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeladler @stormc