Fixed save error while using PWA and enabled save tab groups (#981) #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works fine. Thank you for your contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a save error in Chrome 100 (probably *1) or later when enabled save tab groups and opening PWA.
I commenting in Japanese because the code contains Japanese comments, but feel free to tell me if you want to make them in English.
*1 https://www.reddit.com/r/chrome_extensions/comments/ujzhqp/anyone_came_across_this_exception_in_a_chrome/
Original errors
Tab Session Manager
Save Tab Groups for Tab Session Manager
Applied this PR
Temporary added some logs (not include this PR).