qcustomplot: Fix clang warnings: overrides a member function but is not marked 'override' #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens with clang on at least OS X Sierra: tons of:
I understand this is 3rd party code so you might have preferred using the
-Wno-inconsistent-missing-override
at compile-time and leave the file un-modified, but since the warnings are in the header, one would have to disable the warnings for all the QSyncthingTray source files including this header. So, I went for the approach of adding the missingQ_DECL_OVERRIDE
to the header file. If upstream fixes it, it will fix it in the same way, so there should be no conflicts.This fix allows to build on OS X with 0 warnings, which is a good thing :-)