Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

example-l2pf typo in wit-manifest #530

Merged
merged 1 commit into from
Aug 26, 2020
Merged

example-l2pf typo in wit-manifest #530

merged 1 commit into from
Aug 26, 2020

Conversation

mmjconolly
Copy link
Contributor

No description provided.

richardxia
richardxia approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for figuring this one out, that's a very subtle thing to notice!

@NandkumarJoshi
Copy link
Contributor

Thanks for fixing it !

@mmjconolly
Copy link
Contributor Author

I don’t have permissions to hit the merge button, so I need someone else to press it :)

bsousi5
bsousi5 approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thanks

@bsousi5 bsousi5 merged commit d05c4a1 into v20.05.01-branch Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richardxia richardxia richardxia approved these changes

@bsousi5 bsousi5 bsousi5 approved these changes

@nategraff-sifive nategraff-sifive Awaiting requested review from nategraff-sifive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmjconolly @NandkumarJoshi @richardxia @bsousi5