Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metal_dcache_l1_discard() does not require fence.i #216

Open
TacoGrandeTX opened this issue Dec 27, 2019 · 0 comments
Open

metal_dcache_l1_discard() does not require fence.i #216

TacoGrandeTX opened this issue Dec 27, 2019 · 0 comments

Comments

@TacoGrandeTX
Copy link

Our metal_dcache_l1_discard() contains a fence.i instruction that is not needed and should be removed:

https://github.com/sifive/freedom-metal/blob/v201908-branch/src/cache.c#L161

Invalidating a line in the data cache or the entire data cache has no impact on instruction side accesses and invalidating the I Cache can have a heavy performance impact.
bsousi5 pushed a commit that referenced this issue Apr 8, 2020
@nategraff-sifive
Merge pull request #216 from sifive/update-makefiles
f850df2 
Update all software examples to use wildcards in makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TacoGrandeTX