Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait 100usec before testing FE310 PLL for lock #224

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

nategraff-sifive
Copy link
Contributor

The FE310 PLL needs 100 usec to stabilize before testing the lock signal. This solution assumes that mtime is driven at 32768 Hz for all targets with the FE310 PLL.

Should this be backported to v19.08?

Fixes #213

Copy link
Contributor

@keith-packard keith-packard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good approach; I haven't tested it though, just read through the patch. Thanks for asking for review :-)

src/drivers/sifive_fe310-g000_pll.c Show resolved Hide resolved
src/drivers/sifive_fe310-g000_pll.c Outdated Show resolved Hide resolved
src/drivers/sifive_fe310-g000_pll.c Outdated Show resolved Hide resolved
src/drivers/sifive_fe310-g000_pll.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@bsousi5 bsousi5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The FE310 PLL needs 100 usec to stabilize before testing the lock
signal. This solution assumes that mtime is driven at 32768 Hz for all
targets with the FE310 PLL.

Signed-off-by: Nathaniel Graff <nathaniel.graff@sifive.com>
@nategraff-sifive nategraff-sifive merged commit 1504333 into master Mar 9, 2020
@nategraff-sifive nategraff-sifive deleted the pll-lock-race branch March 9, 2020 21:54
bsousi5 pushed a commit that referenced this pull request Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants