Add faster alternative for checking mjml version #127
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125.
As I suggested in #125, I assume most people that use Rails and Mjml together probably install Mjml via yarn, and the binary is probably in the
node_modules
folder. If it's in there, we can look for the version number directly in the package'spackage.json
, and don't have to actually run it.The benefit is that this way of checking the version is much, much faster.
If this "happy path" check is unsuccessful, it will fall back to the "classic" version.