Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(onprem): enable haproxy monitoring #236

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

ralgozino
Copy link
Member

@ralgozino ralgozino commented Jul 17, 2024

enable metrics scraping from the haproxy loadbalancers and deploy the dashboards and alerts for haproxy from the monitoring module.

Note: I was unsure on setting some auth on the prometheus endpoint. Being that the 8405 port most likely will be accessible only from the inside I think that is enough. But let me know what you think.

Warning

This PR depends on the PR that adds the haproxy package to the monitoring module:

And it is also has been rebased on the following PR that introduces PrometheusAgent mode that we needed to consider:

@ralgozino ralgozino self-assigned this Jul 17, 2024
@ralgozino
Copy link
Member Author

setting this PR as draft. I'll rebase these changes on top of the PR #228 because we'll need to consider the cases introduced by that PR

@ralgozino ralgozino marked this pull request as draft July 17, 2024 14:23
enable metrics scraping from the haproxy loadbalancers and deploy the
dashboards and alerts for haproxy from the monitoring module.
@ralgozino
Copy link
Member Author

ralgozino commented Jul 18, 2024

I've rebased this PR to be branched from the changes introduced by #228 so we could consider the case when monitoring is in PrometheusAgent mode. Notice that you'll see the changes of #228 until it gets merged.

It is now ready for review.

@ralgozino ralgozino marked this pull request as ready for review July 18, 2024 16:08
@nutellinoit nutellinoit changed the base branch from main to feat/v1.29.2 July 31, 2024 08:06
Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be tested after merge

@nutellinoit nutellinoit merged commit 5bb6fc0 into feat/v1.29.2 Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants