Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cert-manager): fix acme image reference #127

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

smerlos
Copy link
Contributor

@smerlos smerlos commented May 20, 2024

No description provided.

@smerlos smerlos self-assigned this May 20, 2024
ralgozino
ralgozino previously approved these changes May 20, 2024
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

nutellinoit
nutellinoit previously approved these changes May 21, 2024
Copy link
Member

@nutellinoit nutellinoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smerlos smerlos dismissed stale reviews from nutellinoit and ralgozino via 860ae44 May 21, 2024 08:44
@smerlos smerlos requested a review from ralgozino May 21, 2024 08:44
README.md Outdated Show resolved Hide resolved
docs/releases/v2.3.1.md Outdated Show resolved Hide resolved
docs/releases/v2.3.1.md Outdated Show resolved Hide resolved
@ralgozino
Copy link
Member

ralgozino commented May 21, 2024

it would be nice to add some tests to the e2e for cert-manager that currently there are none (we just install it)

this can be done later / in another PR

Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent job! <3

@smerlos smerlos merged commit 4fdb489 into main May 23, 2024
2 checks passed
@smerlos smerlos deleted the bugfix/cert-manager-acme branch May 23, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants