Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Makefile, JSON builder and labels to logging module #55

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add Makefile, JSON builder and labels to logging module #55

merged 1 commit into from
Jan 10, 2022

Conversation

nandajavarma
Copy link
Contributor

No description provided.

@nandajavarma nandajavarma self-assigned this Dec 15, 2021
sbruzzese902
sbruzzese902 approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@sbruzzese902 sbruzzese902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the Makefile + bump version approach, good job 💪

@nandajavarma nandajavarma merged commit 4297df6 into master Jan 10, 2022
@nandajavarma nandajavarma deleted the add_label branch January 10, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruzzese902 sbruzzese902 sbruzzese902 approved these changes

@niccoloraspa niccoloraspa Awaiting requested review from niccoloraspa

Assignees

@nandajavarma nandajavarma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandajavarma @sbruzzese902