-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node-exporter): add GOMAXPROCS=1 #112
Conversation
set GOMAXPROCS=1 to avoid CPU throttling in Kubernetes. See prometheus/node_exporter#2530 Fixes #106
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Edit: it would be better to add a patch somewhere (even inline in kustomization.yaml
) to avoid changing the upstream manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment.
why you dont want to fix the upstream but want to add it as a patch later? |
Because we copy the manifests from upstream and altering them means more work in the next release. |
youre right |
I agree, in fact I thought to do it that way but then I forgot. Fixed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Luca Novara <luca@sighup.io>
set
GOMAXPROCS=1
to avoid CPU throttling in Kubernetes.See prometheus/node_exporter#2530
Even keeping the resource limits the error hasn't repeated in +6h adding the env var.
Fixes #106