Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-exporter): add GOMAXPROCS=1 #112

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

ralgozino
Copy link
Member

@ralgozino ralgozino commented Nov 30, 2022

set GOMAXPROCS=1 to avoid CPU throttling in Kubernetes.

See prometheus/node_exporter#2530

Even keeping the resource limits the error hasn't repeated in +6h adding the env var.

Fixes #106

set GOMAXPROCS=1 to avoid CPU throttling in Kubernetes.

See prometheus/node_exporter#2530

Fixes #106
@ralgozino ralgozino self-assigned this Nov 30, 2022
@ralgozino ralgozino added the bug Something isn't working label Nov 30, 2022
@ralgozino ralgozino marked this pull request as ready for review November 30, 2022 18:07
Copy link
Contributor

@lnovara lnovara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Edit: it would be better to add a patch somewhere (even inline in kustomization.yaml) to avoid changing the upstream manifests.

@lnovara lnovara self-requested a review December 1, 2022 10:02
Copy link
Contributor

@lnovara lnovara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment.

@nohant
Copy link
Contributor

nohant commented Dec 1, 2022

LGTM :shipit:

Edit: it would be better to add a patch somewhere (even inline in kustomization.yaml) to avoid changing the upstream manifests.

why you dont want to fix the upstream but want to add it as a patch later?

@lnovara
Copy link
Contributor

lnovara commented Dec 1, 2022

Because we copy the manifests from upstream and altering them means more work in the next release.

@nohant
Copy link
Contributor

nohant commented Dec 1, 2022

Because we copy the manifests from upstream and altering them means more work in the next release.

youre right

@ralgozino
Copy link
Member Author

LGTM :shipit:

Edit: it would be better to add a patch somewhere (even inline in kustomization.yaml) to avoid changing the upstream manifests.

I agree, in fact I thought to do it that way but then I forgot. Fixed.

Thanks!

@ralgozino ralgozino requested a review from lnovara December 1, 2022 10:47
lnovara
lnovara previously approved these changes Dec 1, 2022
Copy link
Contributor

@lnovara lnovara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

katalog/node-exporter/MAINTENANCE.md Outdated Show resolved Hide resolved
Co-authored-by: Luca Novara <luca@sighup.io>
@ralgozino ralgozino merged commit dd360fb into main Dec 1, 2022
@ralgozino ralgozino deleted the fix/node-exporter-cpu-throttling branch December 1, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-exporter targetdown
3 participants