Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement a check to the latest version of the CLI #33

Merged
merged 8 commits into from
Feb 18, 2024

Conversation

ppoliani
Copy link
Contributor

@ppoliani ppoliani commented Feb 4, 2024

Fixes #11

The version is checked against the latest release which we can get from this endpoint. We compare this version to the crate's version.

For this to work we would need:

  1. Publish releases of new versions
  2. The name of the tag should be prefixed with v e.g. v0.1.0
  3. Bump crate version in Cargo.lock upon new release.

Copy link
Contributor

@mimoo mimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great as usual! thanks!

(looks like I can't merge before conflicts are resolved)

)
}

Ok(())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test would be nice :)

@ppoliani
Copy link
Contributor Author

This is great as usual! thanks!

(looks like I can't merge before conflicts are resolved)

Conflicts resolved. One thing we should do before merging it is to create at least one release on GH and use the convention described above.

@ppoliani ppoliani mentioned this pull request Feb 13, 2024
@imikushin imikushin merged commit 34dc952 into sigma0-dev:main Feb 18, 2024
1 check passed
@ppoliani ppoliani deleted the feat/check_version branch February 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make zkbtc CLI check if it is up-to-date
3 participants