use Popen context manager for periodic update process (pypa#2472)

src/virtualenv/seed/wheels/periodic_update.py

@@ -220,16 +220,17 @@ def trigger_update(distribution, for_py_version, wheel, search_dirs, app_data, e
  kwargs = {"stdout": pipe, "stderr": pipe}
  if not debug and sys.platform == "win32":
  kwargs["creationflags"] = CREATE_NO_WINDOW
- process = Popen(cmd, **kwargs) # noqa: S603
- logging.info(
- "triggered periodic upgrade of %s%s (for python %s) via background process having PID %d",
- distribution,
- "" if wheel is None else f"=={wheel.version}",
- for_py_version,
- process.pid,
- )
- if debug:
- process.communicate() # on purpose not called to make it a background process
+
+ with Popen(cmd, **kwargs) as process: # noqa: S603
+ logging.info(
+ "triggered periodic upgrade of %s%s (for python %s) via background process having PID %d",
+ distribution,
+ "" if wheel is None else f"=={wheel.version}",
+ for_py_version,
+ process.pid,
+ )
+ if debug:
+ process.communicate() # on purpose not called to make it a background process
 
 
 def do_update(distribution, for_py_version, embed_filename, app_data, search_dirs, periodic): # noqa: PLR0913