Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI artifacts use invalid filenames #1145

Closed
mgorny opened this issue Apr 23, 2023 · 7 comments · Fixed by #1147
Closed

PyPI artifacts use invalid filenames #1145

mgorny opened this issue Apr 23, 2023 · 7 comments · Fixed by #1147

Comments

@mgorny
Copy link

mgorny commented Apr 23, 2023

The PyPI artifacts for 4.0.0 violate the current version of sdist & wheel specifications by using dots in filenames:

github3.py-4.0.0.tar.gz
github3.py-4.0.0-py3-none-any.whl

However, the directory inside sdist seems to be named correctly:

$ tar -tf github3.py-4.0.0.tar.gz | head -n 1
github3_py-4.0.0/.pre-commit-config.yaml

FWIK hatchling does the correct thing so I guess the release pipeline is broken somewhere and renames the files to non-conformant filenames (but leaving the internal structure correct).

@staticdev
Copy link
Collaborator

@mgorny I used hatch to build and publish based on the config #1144
If I don't do that, PyPI blocks the publish, so I do not have a clear solution for the problem for now.

@mgorny
Copy link
Author

mgorny commented Apr 23, 2023

To be honest, I don't think there's a good solution right now, except for not using dot in project name. Good news is, to the best of my knowledge normalization treats ., _ and - as equivalent, so if you named the project e.g. github3-py this shouldn't break anything depending on it (but please don't take my word on it).

@sigmavirus24
Copy link
Owner

To be honest, I don't think there's a good solution right now, except for not using dot in project name. Good news is, to the best of my knowledge normalization treats ., _ and - as equivalent, so if you named the project e.g. github3-py this shouldn't break anything depending on it (but please don't take my word on it).

I'll go back about 10 years in time and rename it right away

@ofek
Copy link

ofek commented Apr 24, 2023

#1142 (comment)

The nonconformant/"invalid" artifact names predate the latest release:

@staticdev
Copy link
Collaborator

@mgorny we have now 4.0.1

@mgorny
Copy link
Author

mgorny commented Apr 26, 2023

Thanks. I'll test it tomorrow early morning, if that's ok.

@mgorny
Copy link
Author

mgorny commented Apr 27, 2023

It works fine. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants