Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hatch strict naming #1144

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

staticdev
Copy link
Collaborator

@staticdev staticdev commented Apr 23, 2023

Follow up on #1142

@staticdev staticdev added the build Build System and Dependencies label Apr 23, 2023
@staticdev staticdev force-pushed the bugfix/remove-hatch-strict-naming branch 2 times, most recently from 6a84be5 to 0097885 Compare April 23, 2023 17:33
@staticdev staticdev requested a review from sigmavirus24 April 23, 2023 17:39
commands =
python -m build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the standard build interface, not hatch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sigmavirus24 if you try it will break. Not sure if we can fix given the bug in pypi/warehouse#10030

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. I forgot that PyPI are at war with PyPA standards, sigh.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With build -s it works.. thanks @offbyone for the hint.

@staticdev staticdev force-pushed the bugfix/remove-hatch-strict-naming branch from 0097885 to 56ad510 Compare April 23, 2023 20:05
@ofek
Copy link

ofek commented Apr 23, 2023

@mgorny
Copy link

mgorny commented Apr 24, 2023

https://github.com/pypa/hatch/releases/tag/hatchling-v1.14.1

Thanks. Yeah, I suppose that fixes my problem. Still, the situation sucks :-(.

@staticdev
Copy link
Collaborator Author

@sigmavirus24 LGTM? I will publish a bugfix version 4.0.1 using hatchling-v1.14.1.

@staticdev staticdev requested a review from sigmavirus24 April 24, 2023 16:14
@staticdev staticdev merged commit e06c519 into main Apr 24, 2023
@staticdev staticdev deleted the bugfix/remove-hatch-strict-naming branch April 24, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build System and Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants