Fix issue #1137 #1139
Merged
Fix issue #1137 #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere >250 commits in the compare
based on feedback from sigmavirus24 in issue sigmavirus24#1137
amaccormack-lumira
force-pushed
the
fix_issue_#1137
branch
from
3b57f2d
to
702aba7
Compare
for more information, see https://pre-commit.ci
- line length and spacing
…#1137 # Conflicts: # tests/integration/test_repos_repo.py
sigmavirus24
requested changes
Apr 14, 2023
…thod to return iterator
for more information, see https://pre-commit.ci
Closed
Accepting sigmavirus suggestion Co-authored-by: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
Accepting sigmavirus suggestion Co-authored-by: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
for more information, see https://pre-commit.ci
sigmavirus24
approved these changes
Apr 17, 2023
|
Thank you @amaccormack-lumira ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1137, github now allows pagination to get a full issue list out of the compare endpoint, so enabled pagination/iterator on the commits within the Comparison class.
Test added next to the existing test_compare_commits to check for an example with >250 commits change (250 was the previous maximum the api would return)