Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README example does not run due to missing VERSION_KEY #65

Closed
james-pcdr opened this issue Aug 28, 2024 · 1 comment · Fixed by #67
Closed

README example does not run due to missing VERSION_KEY #65

james-pcdr opened this issue Aug 28, 2024 · 1 comment · Fixed by #67
Labels
bug Something isn't working

Comments

@james-pcdr
Copy link

Hello all,
I'm just starting to learn about SigMF. I tried the "Create and save..." example from the homepage, and it gave an error saying 'core:version' is a required property.

Possible solutions:

  1. Add the version to the example:
global_info = {
    SigMFFile.VERSION_KEY: "1.0.0",
    ...
  1. Make 1.0.0 default? In this comment, it looks like perhaps that was intended 🤷‍♂️.

Thanks all for making SigMF!

@Teque5 Teque5 added the bug Something isn't working label Aug 28, 2024
@Teque5
Copy link
Collaborator

Teque5 commented Aug 28, 2024

Yep I think we broke this just recently, need to create a bugfix.

It should use the sigmf.__specification__ value, which is currently 1.2.0.

Thanks for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants