Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SigMFCollection doesn't add specification version to the metadata #82

Closed
GreenK173 opened this issue Dec 12, 2024 · 2 comments
Closed

SigMFCollection doesn't add specification version to the metadata #82

GreenK173 opened this issue Dec 12, 2024 · 2 comments

Comments

@GreenK173
Copy link
Contributor

GreenK173 commented Dec 12, 2024 •
edited
Loading

According to the SigMF specification, the specification version is a required field in a collection metafile. However the currect version doesn't ensure that the field is present. The same issue for SigMFFile was dealt with in issue #65 and PR #67.
@GreenK173 GreenK173 mentioned this issue Dec 12, 2024
Merged
@Teque5
Copy link
Collaborator

Teque5 commented Dec 14, 2024

Yes, a few tests for SigMFCollection are overdue to catch things like this.

@Teque5
Copy link
Collaborator

Teque5 commented Dec 19, 2024

Thanks for opening the PR.

@Teque5 Teque5 closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Teque5 @GreenK173