Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specification version to the metadata in SigMFCollection #83

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

GreenK173
Copy link
Contributor

Solves #82.

@Teque5
Copy link
Collaborator

Teque5 commented Dec 14, 2024

When we create a new SigMFFile we simply override the given self.VERISON_KEY with the current __specification__ since that object is derived from that spec. Similarly here we don't need to check if the version is set and just do self.set_collection_field(self.VERSION_KEY, __specification__).

This is close to what you already have, so just make a quick fix.

@GreenK173
Copy link
Contributor Author

Fixed per above comment.

@Teque5
Copy link
Collaborator

Teque5 commented Dec 19, 2024

Ready to merge after rebase to main.

@Teque5
Copy link
Collaborator

Teque5 commented Dec 19, 2024

Opened #91 to address lack of testing in SigMFCollection, which I realized while reviewing this PR.

@Teque5 Teque5 merged commit f358e30 into sigmf:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants