Add PNG support for transparency #84
Conversation
AmitMY
left a comment
AmitMY
left a comment
There was a problem hiding this comment.
Thanks. Good work! Minor modifications required/should be discussed.
| colors = [np.array(c[::-1]) for c in component.colors] | ||
|
|
||
| @lru_cache(maxsize=None) | ||
| def _point_color(p_i: int): |
There was a problem hiding this comment.
i would add transparency=False, since it can be that we don't want it.
| opacity = c[p_i + idx] | ||
| np_color = colors[p_i % len(component.colors)] * opacity + (1 - opacity) * background_color | ||
| np_color = colors[p_i % len(component.colors)] * opacity + (1 - opacity) * background_color[:3] | ||
| np_color = np.append(np_color, opacity * 255) |
There was a problem hiding this comment.
only when transparency==True
| return img | ||
|
|
||
| def draw(self, background_color: Tuple[int, int, int] = (255, 255, 255), max_frames: int = None): | ||
| def draw(self, background_color: Tuple[int, int, int] = (255, 255, 255), max_frames: int = None, alpha: int = 0): |
There was a problem hiding this comment.
here too I think we should have transparency, not alpha, because this will (IMO) break support for video exports
| background_color += (alpha,) | ||
| int_frames = np.array(np.around(self.pose.body.data.data), dtype="int32") | ||
| background = np.full((self.pose.header.dimensions.height, self.pose.header.dimensions.width, 3), | ||
| background = np.full((self.pose.header.dimensions.height, self.pose.header.dimensions.width, 4), |
There was a problem hiding this comment.
and then I'd split this into two cases, transparent or not
| duration=1000 / self.pose.body.fps, | ||
| loop=0) | ||
|
|
||
| def save_png(self, f_name: str, frames: Iterable[np.ndarray]): |
There was a problem hiding this comment.
i think save_png and save_gif could be both using save_image(f_name: str, frames: ..., format="PNG", transparency=False) for example. right now the code is mostly duplicate
| images[0].save(f_name, | ||
| format="GIF", | ||
| append_images=images, | ||
| append_images=images[1:], |
|
All the changes requested are fixed |
2 participants
Issue for more info : #82