Add PNG support for transparency #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitMY
requested changes
Mar 21, 2024
| @@ -74,7 +74,8 @@ def _draw_frame(self, frame: ma.MaskedArray, frame_confidence: np.ndarray, img) | |||
| @lru_cache(maxsize=None) | |||
| def _point_color(p_i: int): | |||
There was a problem hiding this comment.
i would add transparency=False, since it can be that we don't want it.
| @@ -74,7 +74,8 @@ def _draw_frame(self, frame: ma.MaskedArray, frame_confidence: np.ndarray, img) | |||
| @lru_cache(maxsize=None) | |||
| def _point_color(p_i: int): | |||
| opacity = c[p_i + idx] | |||
| np_color = colors[p_i % len(component.colors)] * opacity + (1 - opacity) * background_color | |||
| np_color = colors[p_i % len(component.colors)] * opacity + (1 - opacity) * background_color[:3] | |||
| np_color = np.append(np_color, opacity * 255) | |||
There was a problem hiding this comment.
only when transparency==True
| @@ -110,7 +111,7 @@ def _point_color(p_i: int): | |||
|
|
|||
| return img | |||
|
|
|||
| def draw(self, background_color: Tuple[int, int, int] = (255, 255, 255), max_frames: int = None): | |||
| def draw(self, background_color: Tuple[int, int, int] = (255, 255, 255), max_frames: int = None, alpha: int = 0): | |||
There was a problem hiding this comment.
here too I think we should have transparency, not alpha, because this will (IMO) break support for video exports
| int_frames = np.array(np.around(self.pose.body.data.data), dtype="int32") | ||
| background = np.full((self.pose.header.dimensions.height, self.pose.header.dimensions.width, 3), | ||
| background = np.full((self.pose.header.dimensions.height, self.pose.header.dimensions.width, 4), |
There was a problem hiding this comment.
and then I'd split this into two cases, transparent or not
| save_all=True, | ||
| duration=1000 / self.pose.body.fps, | ||
| loop=0) | ||
|
|
||
| def save_png(self, f_name: str, frames: Iterable[np.ndarray]): |
There was a problem hiding this comment.
i think save_png and save_gif could be both using save_image(f_name: str, frames: ..., format="PNG", transparency=False) for example. right now the code is mostly duplicate
| @@ -231,11 +235,45 @@ def save_gif(self, f_name: str, frames: Iterable[np.ndarray]): | |||
| images = [Image.fromarray(self.cv2.cvtColor(frame, self.cv2.COLOR_BGR2RGB)) for frame in frames] | |||
| images[0].save(f_name, | |||
| format="GIF", | |||
| append_images=images, | |||
| append_images=images[1:], | |||
|
All the changes requested are fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue for more info : #82